PERF: Reduce verbosity of itk::GaussianOperator warning#3423
Merged
tbirdso merged 1 commit intoInsightSoftwareConsortium:masterfrom May 16, 2022
Merged
Conversation
`itk::GaussianOperator` can be set with a `MaximumKernelWidth` parameter such that a kernel that would otherwise overflow this size is cropped to the maximum width. Cropping to the set maximum width happens frequently in cases such as Gaussian blurring for multiscale pyramid generation and is expected behavior, but the previous warning message makes it seem like a failure case. This commit reduces the verbosity of the message from a warning to a debug printout so that developers can get insights into kernel cropping when needed, but are not alarmed by default warning printouts.
github-actions
bot
added
area:Core
thewtex
approved these changes
May 12, 2022
Contributor
|
In case it is related, ... I am now getting an error message in the |
Contributor
Author
|
It certainly appears related. Interesting that this did not show up in CI. @Leengit could you please share details on your build platform? |
Contributor
|
Linux 5.13.0-41-generic #46~20.04.1-Ubuntu SMP Wed Apr 20 13:16:21 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
Contributor
Author
|
Thank you, on review I am also able to see failures in CDash Expected Nightly Builds. My guess is that this means I will open an issue to track. If we can't use debug printouts here I would be in favor of removing the warning message entirely. It could be useful in certain scenarios where the user is unaware of a default truncation parameter, but in general it is simply informing the user that execution is proceeding according to design. |
Contributor
|
Perhaps a quick, sloppy fix to get the |
This was referenced May 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
itk::GaussianOperatorcan be set with aMaximumKernelWidthparametersuch that a kernel that would otherwise overflow this size is cropped to
the maximum width. Cropping to the set maximum width happens frequently
in cases such as Gaussian blurring for multiscale pyramid generation and
is expected behavior, but the previous warning message makes it seem
like a failure case. This commit reduces the verbosity of the message
from a warning to a debug printout so that developers can get insights
into kernel cropping when needed, but are not alarmed by default warning
printouts.
Previous behavior: Warning whenever Gaussian kernel is correctly truncated to user specifications.
New behavior: No printout unless explicitly enabled.
PR Checklist
Refer to the ITK Software Guide for
further development details if necessary.